Tweak the pitch deck a little #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tweaks the pitch deck to be less specific on the order of partnership conversations. * Tweaks docker-etcd to automatically add the etcd link
|
This PR has passed 'Verify' and is ready for review and approval! |
| @@ -1,2 +1,2 @@ | |||
| #!/bin/bash -x | |||
| docker run --link=bldr_etcd_1:etcd $@ | |||
| docker run -e BLDR_CONFIG_ETCD=http://etcd:4001 --link=bldr_etcd_1:etcd $@ | |||
There was a problem hiding this comment.
Yep, that seems more portable and better
|
excellent! @delivery approve |
|
Change: 83bd68e8-7885-4362-af3b-4014537e50aa approved by: @fnichol |
chef-delivery
added a commit
that referenced
this pull request
Oct 29, 2015
Merged change 83bd68e8-7885-4362-af3b-4014537e50aa From review branch demo-update into master Signed-off-by: fnichol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conversations.