Adding docker build support to studios #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a new 'baseimage' studio type, for making a docker base image from a package * A 'dockerize' command that does the needful of building your studio, then running `docker build`. * Supports building arbitrary docker containers from arbitrary package lists The new path for getting a docker container is something like: ```bash $ studio enter $ build plan/redis $ dockerize chef/redis ``` You can also just dockerize any-old package in the depot. Works as long as you have a docker socket handy. Next up is figuring out why we have some strange behavior coming out of bldr-build, and removing the docker features from it entirely. Yay smaller tools!
|
This PR has passed 'Verify' and is ready for review and approval! |
|
Sweet bash magic
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Feb 18, 2016
Merged change 5b2efefa-ec9b-461b-8fde-5660bb889c21 From review branch docker-builds into master Signed-off-by: reset <[email protected]>
|
This PR has passed 'Acceptance' and is ready to be delivered! |
| @@ -1,4 +1,5 @@ | |||
| set -eu | |||
| BLDR_REPO=${BLDR_REPO:-"http://52.11.158.96:32768"} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from a package
docker build.lists
The new path for getting a docker container is something like:
You can also just dockerize any-old package in the depot. Works as long
as you have a docker socket handy.
Next up is figuring out why we have some strange behavior coming out of
bldr-build, and removing the docker features from it entirely. Yay
smaller tools!