[bldr-build] Add fix_shebang, pkg_interpreter_for #231
Conversation
|
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
|
This PR has passed 'Verify' and is ready for review and approval! |
| # | ||
| # For a single target: | ||
| # | ||
| # fix_shebang node_modules/.bin/concurrent chef/coreutils:bin/env |
There was a problem hiding this comment.
@fnichol what do you think about this being a : rather than 3 arguments? I think I like it, but it's a new introduction to the API. Might be too much magic. @jtimberman ?
jtimberman
force-pushed
the
jtimberman/fix-shebang
branch
from
6161546 to
f16ffff
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
| # ### pkg_interpreters | ||
| # An array of binaries that are used as interpreters in shebang lines for scripts. | ||
| # ``` | ||
| # pkg_interpreters=(bash sh) |
There was a problem hiding this comment.
Possibly need to update the example with the relative path to the binary? For example in the bash Plan it was pkg_interpreters=(bin/bash bin/sh)
There was a problem hiding this comment.
Already updated on my local branch 😁
jtimberman
force-pushed
the
jtimberman/fix-shebang
branch
from
f16ffff to
f1f55e0
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
This commit introduces the fix_shebang and pkg_interpreter_for functions. * fix_shebang is used to modify hardcoded shebang lines in interpreted scripts to use the paths in the INTERPRETERS metadata * pkg_interpreter_for finds the specified interpreter in the INTERPRETERS metadata for the given package * We now support adding pkg_interpreters in plan.sh to specify binaries of interpreters provided by the package * The interpreters are added to the new INTERPRETERS metadata Expose the interpreters using the subdirectory of their binary, for example bin/bash, because some packages may have directories besides bin where their interpreters are such as sbin or libexec.
jtimberman
force-pushed
the
jtimberman/fix-shebang
branch
from
f1f55e0 to
421e2c5
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
|
|
|
@delivery approve |
Merged change fbb04470-c138-49af-9648-d308ba2e6678 From review branch jtimberman/fix-shebang into master Signed-off-by: fnichol <[email protected]>
|
This PR has passed 'Acceptance' and is ready to be delivered! |
This commit introduces the fix_shebang and pkg_interpreter_for functions.