Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plan] Add plan for current Go (1.6) & for Go 1.4.3. #240

Merged
merged 1 commit into from
Mar 10, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Feb 24, 2016

Normally we would not care so much about an older release of software,
however as of 1.5 Go is built from a pre-exisiting version of Go. Hence
the 1.4.3 plans is largely a bootstrapping maneuver but is still
generically useful.

@fnichol
Copy link
Collaborator Author

fnichol commented Feb 24, 2016

Surprise, slack time task!

gif-keyboard-5065963463667820219

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@bookshelfdave
Copy link
Contributor

works great!
gif-keyboard-6388784828449473977

@@ -0,0 +1,111 @@
pkg_name=go
pkg_derivation=chef
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnichol we swapped this to pkg_origin in the master branch. If you want to update this PR we can merge it in!

Normally we would not care so much about an older release of software,
however as of 1.5 Go is built from a pre-exisiting version of Go. Hence
the 1.4.3 plans is largely a bootstrapping maneuver but is still
generically useful.
@fnichol
Copy link
Collaborator Author

fnichol commented Mar 10, 2016

@reset Got it, updated to pkg_origin and rebased against current master. Ready to go.

gif-keyboard-17094741458293067712

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Mar 10, 2016

@delivery approve

chef-delivery added a commit that referenced this pull request Mar 10, 2016
Merged change eea28105-4308-4121-aa65-24e0a9586c66

From review branch fnichol/plan-go into master

Signed-off-by: reset <[email protected]>
@chef-delivery chef-delivery merged commit 4e3b4fe into master Mar 10, 2016
@chef-delivery chef-delivery deleted the fnichol/plan-go branch March 10, 2016 19:39
@chef-delivery
Copy link
Contributor

Change: eea28105-4308-4121-aa65-24e0a9586c66 approved by: @reset

@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants