Functional tests passing in new studios #243
Conversation
adamhjk
commented
Feb 25, 2016
adamhjk
commented
- Adds chef/rngd and chef/gcc-libs to the bldr plan
- Adds iptables plan
- Fix rngd plan to build correctly
- Run tests in the studio
- Fix the internal functional test fixture plans
- Fix error reporting for gpg
- Add a CommandArgs struct for internal test commands
- Use the chef/iptables for partitioning
- Ignore tests that are flapping
|
This PR has passed 'Verify' and is ready for review and approval! |
* Adds chef/rngd and chef/gcc-libs to the bldr plan * Adds iptables plan * Fix rngd plan to build correctly * Run tests in the studio * Fix the internal functional test fixture plans * Fix error reporting for gpg * Add a CommandArgs struct for internal test commands * Use the chef/iptables for partitioning * Ignore tests that are flapping
| pkg_service_run="sbin/rngd -f -r /dev/urandom" | ||
| pkg_service_user=root | ||
|
|
||
| do_build() { | ||
| ./autogen.sh && ./configure --prefix=$pkg_prefix && make |
There was a problem hiding this comment.
Is this because we're grabbing it from sourceforge now?
|
Gotta rebase again but this looks good! |
adamhjk
force-pushed
the
fix-functional-tests
branch
from
3836474 to
fa5c7e2
Compare
|
Rebase is done. |
|
This PR has passed 'Verify' and is ready for review and approval! |
| @@ -45,7 +45,11 @@ clean: | |||
|
|
|||
| image: | |||
| if [ -n "${force}" -o -z "`$(docker_cmd) images -q $(dimage)`" ]; then \ | |||
| $(docker_cmd) build $(build_args) -t $(dimage) .; \ | |||
| if [ -n "${force}" ]; then \ | |||
| $(docker_cmd) build --no-cache $(build_args) -t $(dimage) .; \ | |||
There was a problem hiding this comment.
Ugh, were you getting old cached image layers?
There was a problem hiding this comment.
Sometimes I just want an image that has a newer bldr, bpm, or studio. No way to do that if the line remains the same, other than forcing a rebuild from scratch.
|
@delivery approve |
Merged change 42de7c8b-c159-40cd-af8c-99efb5eb8b37 From review branch fix-functional-tests into master Signed-off-by: fnichol <[email protected]>
|
|
|
This PR has passed 'Acceptance' and is ready to be delivered! |
