Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Page #244

Merged
merged 1 commit into from
Feb 25, 2016
Merged

Project Page #244

merged 1 commit into from
Feb 25, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 25, 2016

Add a project detail page. smith/nethack is one that has data populated
that you can look at.

Also:

  • Replace "derivation" with "origin"
  • Use undefined and List() in initialState instead of null and
    []
  • Fix layout on create project form

Add a project detail page. smith/nethack is one that has data populated
that you can look at.

Also:

* Replace "derivation" with "origin"
* Use `undefined` and `List()` in initialState instead of `null` and
  `[]`
* Fix layout on create project form
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Feb 25, 2016

@smith I'll be sure to update derivation to origin in the other places of the code as well

@reset
Copy link
Collaborator

reset commented Feb 25, 2016

Loving how nicely this feels!

gif-keyboard-14259725476206341275

@delivery approve

chef-delivery added a commit that referenced this pull request Feb 25, 2016
Merged change 738f7360-838a-481b-8cdb-47715dab3f13

From review branch nls/project into master

Signed-off-by: reset <[email protected]>
@chef-delivery chef-delivery merged commit 8491005 into master Feb 25, 2016
@chef-delivery chef-delivery deleted the nls/project branch February 25, 2016 21:51
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants