Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Accounts page #248

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Linked Accounts page #248

merged 1 commit into from
Mar 4, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 29, 2016

Make a page for linked accounts. You should be able to go to the linked
accounts in the sidebar, link an imaginary account, unlink it, and go to
the create projects page.

Also make the sidebar items bold when they are selected.

<meta name="google-site-verification" content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA">
<meta name="google-analytics" content="UA-3769691-2">

<meta content="collector.githubapp.com" name="octolytics-host" /><meta content="github" name="octolytics-app-id" /><meta content="A78E33FA:0916:2A0992E:56D47E24" name="octolytics-dimension-request_id" /><meta content="9912" name="octolytics-actor-id" /><meta content="smith" name="octolytics-actor-login" /><meta content="fe645ed676412145a9390e21b74bac45cfee5aefcb25e4c28b5669bff7bb9744" name="octolytics-actor-hash" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this GH analytics stuff and do we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a page saved from my browser to look like you're at the github auth page. We could take stuff out of it but it's going to be replaced with real github auth at some point so I don't see any point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bookshelfdave
Copy link
Contributor

works ok, but I don't understand most of the stuff in web/fixtures/authorizeGitHub.html.

broken image:
bldr

@smith
Copy link
Contributor Author

smith commented Mar 3, 2016

@metadave You should be able to see the broken image now. You'll need to npm install though.

@bookshelfdave
Copy link
Contributor

@smith it works!

@reset
Copy link
Collaborator

reset commented Mar 3, 2016

@smith this one is gonna need some manual intervention as well

Make a page for linked accounts. You should be able to go to the linked
accounts in the sidebar, link an imaginary account, unlink it, and go to
the create projects page.

Also make the sidebar items bold when they are selected.
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@smith
Copy link
Contributor Author

smith commented Mar 4, 2016

@delivery approve

chef-delivery added a commit that referenced this pull request Mar 4, 2016
Merged change 98ca2610-b8a2-4771-a7b4-25c93326813b

From review branch nls/link into master

Signed-off-by: smith <[email protected]>
@chef-delivery chef-delivery merged commit fa40c7c into master Mar 4, 2016
@chef-delivery chef-delivery deleted the nls/link branch March 4, 2016 04:15
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants