Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build bldr-web in a studio #265

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Conversation

jtimberman
Copy link
Contributor

This commit introduces changes that allow bldr-web to be built in a
studio:

  • Add build deps for installing and building npm modules
  • Change the interpreter in the source files, not the symlinks, for the
    node module binaries
  • Skip the prompt for phone-home statistics for the typings npm module
  • Use sh, not bash, for hooks because busybox doesn't have a bash

This commit introduces changes that allow bldr-web to be built in a
studio:

* Add build deps for installing and building npm modules
* Change the interpreter in the source files, not the symlinks, for the
  node module binaries
* Skip the prompt for phone-home statistics for the typings npm module
* Use sh, not bash, for hooks because busybox doesn't have a bash
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@smith
Copy link
Contributor

smith commented Mar 8, 2016

gif-keyboard-16243391838098915006

@delivery approve

chef-delivery added a commit that referenced this pull request Mar 8, 2016
Merged change 14cb3f2f-1e29-4c31-b3bf-2e43baa4c3c8

From review branch jtimberman/studio-bldr-web into master

Signed-off-by: smith <[email protected]>
@chef-delivery chef-delivery merged commit dc76398 into master Mar 8, 2016
@chef-delivery chef-delivery deleted the jtimberman/studio-bldr-web branch March 8, 2016 18:30
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants