Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of httpd plan. #266

Merged
merged 3 commits into from
Mar 9, 2016
Merged

Initial version of httpd plan. #266

merged 3 commits into from
Mar 9, 2016

Conversation

juliandunn
Copy link
Contributor

No description provided.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

# documents. By default, all requests are taken from this directory, but
# symbolic links and aliases may be used to point to other locations.
#
DocumentRoot "/opt/bldr/srvc/httpd/htdocs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW in nginx, we use data:

root   /opt/bldr/srvc/nginx/data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you do for cgi-bin and things like that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears the convention comes from the pkg_srvc* variables in bldr-build.

  • $pkg_srvc: Where the running service is; /opt/bldr/srvc/$pkg_name
  • $pkg_srvc_data: Service data; /opt/bldr/srvc/$pkg_name/data
  • $pkg_srvc_var: Variable state; /opt/bldr/srvc/$pkg_name/var
  • $pkg_srvc_config: Configuration; /opt/bldr/srvc/$pkg_name/config
  • $pkg_srvc_static: Static data; /opt/bldr/srvc/$pkg_name/static

So perhaps data/htdocs, data/cgi-bin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah that would make sense. Thanks

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@@ -0,0 +1,4 @@
#!/bin/sh
mkdir -p /opt/bldr/srvc/httpd/htdocs
mkdir -p /opt/bldr/srvc/httpd/logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about logs being in an /opt location, seems it should be /var/opt. But I'm not sure how much we care about "FHS" conventions here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I commented above, we have

  • $pkg_srvc_var: Variable state; /opt/bldr/srvc/$pkg_name/var

from bldr-build. I think given this, we would have /opt/bldr/srvc/httpd/var/logs for the log configuration in this plan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm pretty sure we're on the FFHS path here 😀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is fine, but the biggest issue we're probably going to face is "where the hell are the logs?!"

Of course, documentation is key with that.

@smith
Copy link
Contributor

smith commented Mar 8, 2016

works!
gif-keyboard-3946963957317052327

@delivery approve

@chef-delivery
Copy link
Contributor

Failed to unknown change: 54f1c58e-8a41-403d-9a4d-0115ab8c7f03
Delivery does not understand this command. @smith

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@juliandunn
Copy link
Contributor Author

@jtimberman did you have more modifications to this plan or are we gtg?

@jtimberman
Copy link
Contributor

I have no other modifications.

@delivery approve

chef-delivery added a commit that referenced this pull request Mar 9, 2016
Merged change 54f1c58e-8a41-403d-9a4d-0115ab8c7f03

From review branch jcd/apache2-plan into master

Signed-off-by: jtimberman <[email protected]>
@chef-delivery chef-delivery merged commit bcaa699 into master Mar 9, 2016
@chef-delivery chef-delivery deleted the jcd/apache2-plan branch March 9, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants