bldr-build and studio improvements #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing the SHA256 checksums to the manifest, files that have spaces in the names are not escaped/quoted, so errors will get displayed and those files will not be included in the manifest. Adding the `-print0` option to find, along with the `-0` option to xargs resolves this problem. We love colorized prompts. However, in most of our default terminal settings the escape codes cause weird behavior that prevents the terminal from displaying really long commands. For now, let's just have a simple prompt with no color.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
looks good
|
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Mar 16, 2016
Merged change 2c7b4b69-ec1e-44e7-9f51-79e6fc8cb06c From review branch jtimberman/studio-build-improvements into master Signed-off-by: jtimberman <[email protected]>
|
Change: 2c7b4b69-ec1e-44e7-9f51-79e6fc8cb06c approved by: @jtimberman |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the SHA256 checksums to the manifest, files that have
spaces in the names are not escaped/quoted, so errors will get
displayed and those files will not be included in the manifest. Adding
the
-print0option to find, along with the-0option to xargsresolves this problem.
We love colorized prompts. However, in most of our default terminal
settings the escape codes cause weird behavior that prevents the
terminal from displaying really long commands. For now, let's just
have a simple prompt with no color.