Split functionality into five crates from one #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bldr - the initial crate mostly unchanged (for now) * core - shared functionality between any bldr crate * depot - contains the depot server * depot-core - shared functionality between any depot components * depot-client - an http client to the depot server
|
This PR has passed 'Verify' and is ready for review and approval! |
|
Two questions:
|
|
|
|
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Mar 17, 2016
Merged change 378dd65a-b60a-4fec-a18c-6a960cb978a1 From review branch componentize into master Signed-off-by: adam <[email protected]>
|
Change: 378dd65a-b60a-4fec-a18c-6a960cb978a1 approved by: @adamhjk |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large code upheaval so I have left quite a bit of duplicate code in places since we have code inflight. There are largely no actual changes here aside from making the compiler happy with the new location of code paths when necessary. The depot crate contains the largest amount of actual changes.
The Depot crate now generates an executable artifact of it's own which contains a clap CLI. This is the majority of the new bits.