fix bug where all data blocks were not extracted to file #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has passed 'Verify' and is ready for review and approval! |
|
|
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Mar 17, 2016
Merged change 590f6b11-fd06-414e-a192-318fabcb312e From review branch extract-all-blocks into master Signed-off-by: adam <[email protected]>
|
Change: 590f6b11-fd06-414e-a192-318fabcb312e approved by: @adamhjk |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A loop around reading and writing data blocks was missing causing some files to be written out containing a bunch of null padding. This is because the header contains the size of the file to write and then the file is filled out by reading and writing through a buffer.
You can see the C example here which I built the library around when I made this mistake: https://github.com/libarchive/libarchive/blob/b9d0b46eb05b0f1e6c832512c2c6b5d782db58d1/examples/untar.c#L208-L220