Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Config File Gossip #309

Merged
merged 1 commit into from
Mar 26, 2016
Merged

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Mar 21, 2016

Configuration file injection

  • Adds a new 'Inject' protocol for injecting rumors without being a
    member
  • Adds a new config_file and config_file_list, for tracking
    configuration files shared by gossip
  • Writes out any files for our service group, and runs a new file_updated
    hook when they are updated
  • Changes the hook display output to use the hook name as the preamble
  • If the file is named 'gossip.toml', we wire it through to the service
    configuration, re-ender our hooks, and execute the reconfigure hook.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

1 similar comment
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol fnichol force-pushed the fnichol/config-file-gossip branch from 68529be to f76d4f2 Compare March 22, 2016 19:30
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol fnichol force-pushed the fnichol/config-file-gossip branch from f76d4f2 to 41adce7 Compare March 22, 2016 19:45
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

1 similar comment
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol fnichol force-pushed the fnichol/config-file-gossip branch from 3399ec8 to 22b9efa Compare March 23, 2016 16:42
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol fnichol force-pushed the fnichol/config-file-gossip branch from 22b9efa to 269c1fc Compare March 24, 2016 20:36
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@adamhjk adamhjk force-pushed the fnichol/config-file-gossip branch 3 times, most recently from b183b26 to 6c37bef Compare March 26, 2016 00:09

pub fn on_disk_path(&self) -> PathBuf {
if &self.file_name == "gossip.toml" {
PathBuf::from(format!("/opt/bldr/srvc/{}/{}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the constants from the FS module

* Adds a new 'Inject' protocol for injecting rumors without being a
  member
* Adds a new config_file and config_file_list, for tracking
  configuration files shared by gossip
* Writes out any files for our service group, and runs a new file_updated
  hook when they are updated
* Changes the hook display output to use the hook name as the preamble
* If the file is named 'gossip.toml', we wire it through to the service
  configuration, re-ender our hooks, and execute the reconfigure hook.
@adamhjk adamhjk force-pushed the fnichol/config-file-gossip branch from 6c37bef to 0ac2800 Compare March 26, 2016 20:51
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@adamhjk
Copy link
Contributor

adamhjk commented Mar 26, 2016

Fixed up all the things mentioned by @reset , in addition to cleaning up the failing tests (I removed them - they were basically just checking debug output, and were pretty brittle. If we really want to test that we don't break the output, lets write a functional instead).

gif-keyboard-8330178486058286423

@adamhjk
Copy link
Contributor

adamhjk commented Mar 26, 2016

@delivery approve

@chef-delivery chef-delivery merged commit d6b7e16 into master Mar 26, 2016
@chef-delivery chef-delivery deleted the fnichol/config-file-gossip branch March 26, 2016 21:09
@chef-delivery
Copy link
Contributor

Change: 00b73b88-e2ed-46b3-ae8f-3e76ef40a327 approved by: @adamhjk

@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants