-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Config File Gossip #309
Conversation
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
This PR has passed 'Verify' and is ready for review and approval! |
68529be
to
f76d4f2
Compare
This PR has passed 'Verify' and is ready for review and approval! |
f76d4f2
to
41adce7
Compare
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
This PR has passed 'Verify' and is ready for review and approval! |
3399ec8
to
22b9efa
Compare
This PR has passed 'Verify' and is ready for review and approval! |
22b9efa
to
269c1fc
Compare
This PR has passed 'Verify' and is ready for review and approval! |
b183b26
to
6c37bef
Compare
|
||
pub fn on_disk_path(&self) -> PathBuf { | ||
if &self.file_name == "gossip.toml" { | ||
PathBuf::from(format!("/opt/bldr/srvc/{}/{}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the constants from the FS module
* Adds a new 'Inject' protocol for injecting rumors without being a member * Adds a new config_file and config_file_list, for tracking configuration files shared by gossip * Writes out any files for our service group, and runs a new file_updated hook when they are updated * Changes the hook display output to use the hook name as the preamble * If the file is named 'gossip.toml', we wire it through to the service configuration, re-ender our hooks, and execute the reconfigure hook.
6c37bef
to
0ac2800
Compare
This PR has passed 'Verify' and is ready for review and approval! |
Fixed up all the things mentioned by @reset , in addition to cleaning up the failing tests (I removed them - they were basically just checking debug output, and were pretty brittle. If we really want to test that we don't break the output, lets write a functional instead). |
@delivery approve |
Change: 00b73b88-e2ed-46b3-ae8f-3e76ef40a327 approved by: @adamhjk |
This PR has passed 'Acceptance' and is ready to be delivered! |
Configuration file injection
member
configuration files shared by gossip
hook when they are updated
configuration, re-ender our hooks, and execute the reconfigure hook.