Cleaning up a panic at exit #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty sure we should be stopping all our actors before we exit, just out of kindness (and hidden race conditions). But, I'm not sure what went wrong, and this trades a race condition for a certain constant panic. Lets fix it in post :) Love, Adam
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 5, 2015
Merged change 96b87f85-2040-4a88-9cb6-c1fc490a852e From review branch cleanup-exit-panic into master Signed-off-by: adam <[email protected]>
|
Change: 96b87f85-2040-4a88-9cb6-c1fc490a852e approved by: @adamhjk |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure we should be stopping all our actors before we exit,
just out of kindness (and hidden race conditions). But, I'm not sure
what went wrong, and this trades a race condition for a certain constant
panic. Lets fix it in post :)
Love,
Adam