Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust to 1.7.0 #322

Merged
merged 1 commit into from
Mar 28, 2016
Merged

Upgrade Rust to 1.7.0 #322

merged 1 commit into from
Mar 28, 2016

Conversation

juliandunn
Copy link
Contributor

We have to have Rust 1.7.0 in the tree otherwise Habitat itself will refuse to compile with this:

src/config_file.rs:93:32: 93:42 error: use of unstable library feature 'convert': waiting on RFC revision (see issue #27729)
src/config_file.rs:93             checksum: checksum.as_slice().to_hex(),
                                                     ^~~~~~~~~~
src/config_file.rs:112:32: 112:42 error: use of unstable library feature 'convert': waiting on RFC revision (see issue #27729)
src/config_file.rs:112             checksum: checksum.as_slice().to_hex(),
                                                      ^~~~~~~~~~
src/config_file.rs:173:23: 173:33 error: use of unstable library feature 'convert': waiting on RFC revision (see issue #27729)
src/config_file.rs:173         Ok(h.finish().as_slice().to_hex())
                                             ^~~~~~~~~~
error: aborting due to 3 previous errors
Could not compile `bldr`.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Mar 28, 2016

@delivery approve

gif-keyboard-1348696555493017544

@chef-delivery
Copy link
Contributor

Failed to unknown change: 3764b785-0fd0-44af-b653-137dd48ae5c3
Delivery does not understand this command. @reset

@reset
Copy link
Collaborator

reset commented Mar 28, 2016

@delivery approve

@chef-delivery chef-delivery merged commit 94c24df into master Mar 28, 2016
@chef-delivery
Copy link
Contributor

Change: 3764b785-0fd0-44af-b653-137dd48ae5c3 approved by: @reset

@chef-delivery chef-delivery deleted the jcd/upgrade-rust branch March 28, 2016 18:26
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants