Audit all Error types in bldr crate .vs core create and remove unused Cargo dependencies in bldr crate.
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change compares all error types in the `bldr` crate against what is currently in the `bldr_core` crate and drops any error types that are no longer used due to refactoring, reimplementation, etc. Additonally, the Error enums are alphabetized in order to make future comparison audits a simpler task. Also, this means there is one natural place for a net-new enum: where it sits lexically.
This change removes 8 dependencies that no longer have to be build (or rebuilt) and should lead to quicker compile times.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
|
Change: e55e9903-7165-472e-a8a4-e3f9ee7898b8 approved by: @reset |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details…