Rename Bldr crates to Habitat crates. #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is a large, breaking change to the entire ecosystem and
codebase. Guess what? The project formerly known as Bldr is now Habitat.
Cool, no?
This is the first move at migrating all codebases, toolsets, and related
packages over to Habitat. The Rust crate components change name
here--most interestingly the crate formerly known as 'bldr' is now the
Habitat Supervior, known in code as `habitat_sup` and invoked on the
command line with `hab-sup`. Only the names of the crate projects and
associated `extern crate`, `use`, and error types have been changed
over, but this leaves us with a building system.
The following is a summary of the crate changes as they appear now, in
pseudocode:
```
habitat_core = {
directory: core
crate_lib: habitat_core
}
habitat_depot_core = {
directory: depot-core
crate_lib: habitat_depot_core
}
habitat_depot_client = {
directory: depot-client
crate_lib: habitat_depot_client
}
habitat_depot = {
directory: depot
crate_lib: habitat_depot
crate_bin: hab-depot
}
habitat_sup = {
directory: sup
crate_lib: habitat_sup
crate_bin: hab-sup
}
```
The unit tests pass, the docs generate, but the functional suite is not
entirely passing due to changes needed in Studio. Here is a current
summary:
```
failures:
bldr::gossip::incarnation_updates_on_suspicion
bldr::gossip::isolated_members_find_a_way_to_rejoin
bldr::gossip::members_are_gossiped
bldr::gossip::ressurection_of_permanent_members
bldr::gossip::routes_around_failure
bldr::gossip::two_supervisors_detect_failure
bldr::gossip::two_supervisors_link
bldr::topology::leader::elects_a_leader
bldr::topology::leader::minimum_quorum
test result: FAILED. 13 passed; 9 failed; 8 ignored; 0 measured
```
This change runs the test suites in an order from lower level components up to higher level components. Additionally, non-runnable compoenents (i.e. library-only crates) aren't directly built with the `make all` target. This is because these library compoenents are built when building the `hab-sup` and `hap-depot` binaries. This cuts the run time of `make all` roughly in half--on my system from ~10 minutes to ~5 minutes.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
looks good, merge when ready
|
|
@fnichol you'll want to update the bldr-depot plan as well! |
|
@reset Honestly, I'm not even sure if that plan would even build properly--there is a lot of interactions with |
|
|
|
@delivery approve |
|
Change: 42bf6eb0-71b9-44e3-9e66-9f068a6cd6be approved by: @adamhjk |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is a large, breaking change to the entire ecosystem and codebase.
Guess what? The project formerly known as Bldr is now Habitat. Cool, no?
This is the first move at migrating all codebases, toolsets, and related
packages over to Habitat. The Rust crate components change name here--most
interestingly the crate formerly known as 'bldr' is now the Habitat Supervior,
known in code as
habitat_supand invoked on the command line withhab-sup.Only the names of the crate projects and associated
extern crate,use, anderror types have been changed over, but this leaves us with a building system.
The following is a summary of the crate changes as they appear now, in
pseudocode:
The unit tests pass, the docs generate, but the functional suite is not
entirely passing due to changes needed in Studio. Here is a current summary:
There are 2 additional changes in this set, see the commit messages for more details.