Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package lists of origin/name/version work #339

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Mar 31, 2016

gif-keyboard-10634262941944314610

* Set the `depotUrl` in habitat.conf.js to "http://52.37.151.35:9632"
* Go to http://localhost:3000/#/pkgs/chef/discourse
* A list of discourse packages in the chef origin should show up
* Clicking on the breadcrumbs should work as expected
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@bookshelfdave
Copy link
Contributor

looks good.

probably not related to this PR, but the manifest formatting needs some work:

habitat

@bookshelfdave
Copy link
Contributor

gif-keyboard-13257041447491263506

@smith
Copy link
Contributor Author

smith commented Mar 31, 2016

@metadave The manifest is sent in what appears to be markdown, so on the client we're just rendering the markdown. We should be in continuing conversations about what data the API provides and how it's presented, but for now we're presenting the data that's available in the most obvious way possible.

@smith
Copy link
Contributor Author

smith commented Mar 31, 2016

@delivery approve

@chef-delivery chef-delivery merged commit 6d59b87 into master Mar 31, 2016
@chef-delivery
Copy link
Contributor

Change: 35fe74df-1403-4282-a368-71a35f9b8f7f approved by: @smith

@chef-delivery chef-delivery deleted the nls/real-origins branch March 31, 2016 15:03
@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants