-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hab] Creation of hab
binary.
#342
Conversation
This PR has passed 'Verify' and is ready for review and approval! |
8768b06
to
bf6893f
Compare
This PR has passed 'Verify' and is ready for review and approval! |
1 similar comment
This PR has passed 'Verify' and is ready for review and approval! |
This change introduces a new binary into the Habitat ecosystem: the `hab` command, which is intended to be a user-facing command set, seperate from the Habitat Supervisor (called via the `hab-sup` binary). The current implementation is a first step: part prototype and part implementation. It shows a possible command set layout (i.e. a `hab <NOUN> <VERB>` structure) and short command aliases. Here is the current output from the help usage: ``` hab 0.4.0 Authors: The Habitat Maintainers <[email protected]> "A Habitat is the natural environment for your services" - Alan Turing USAGE: hab [FLAGS] [SUBCOMMAND] FLAGS: -h, --help Prints help information -V, --version Prints version information SUBCOMMANDS: arch Runs Habitat package archive commands help Prints this message or the help message of the given subcommand(s) pkg Runs Habitat package commands sup Runs Habitat supervisor commands ALIASES: install Alias for: 'pkg install' start Alias for: 'sup start' ``` Additionally, subcommand and alias delegation has a first-pass implementation. This is used for the `hap sup` subcommand, which actually executes the `hap-sup` binary via an `execv(3)` system call. In other words the `hap` program becomes the `hap-sup` program, passing along all behavior including help dialogs. The `hab start` alias also delegates directly to the `hab-sup start` subcommand.
124cd6b
to
85aa340
Compare
Current status of
Current status of
|
Note that the origin has not yet changed, but allows us to build and run packages with the new artifact names from a Depot.
hab
binary.hab
binary.
This PR has passed 'Verify' and is ready for review and approval! |
pub mod ident; | ||
pub mod install; | ||
|
||
pub use self::archive::PackageArchive; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly.
@fnichol what is the |
@reset I'm hoping this could be a temporary crate that is hosting some common code to both the |
LGTM |
@fnichol looks good to me as long as the |
@delivery approve |
Failed to approve change: 620a3fe4-b22d-4451-ac4f-da849828a3a3 @reset |
@delivery approve |
Failed to approve change: 620a3fe4-b22d-4451-ac4f-da849828a3a3 @reset |
This change introduces a new binary into the Habitat ecosystem: the
hab
command, which is intended to be a user-facing command set,seperate from the Habitat Supervisor (called via the
hab-sup
binary).The current implementation is a first step: part prototype and part
implementation. It shows a possible command set layout (i.e. a
hab <NOUN> <VERB>
structure) and short command aliases. Here is the current output fromthe help usage:
Additionally, subcommand and alias delegation has a first-pass implementation.
This is used for the
hap sup
subcommand, which actually executes thehap-sup
binary via anexecv(3)
system call. In other words thehap
program becomes the
hap-sup
program, passing along all behavior includinghelp dialogs. The
hab start
alias also delegates directly to thehab-sup start
subcommand.