Global UI Styles for Habitat Web #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,9 @@ | |||
|
|
|||
| @import "normalize"; | |||
|
|
|||
| // Include web fonts | |||
| @import url(https://fonts.googleapis.com/css?family=Montserrat:400,700|Titillium+Web:400,400italic,600); | |||
There was a problem hiding this comment.
Note that if we're going to ship this for on-prem use, we'll need to include the fonts on disk instead of calling out to Google's CDN. It's fine here for now.
|
Wow nice! A few things:
|
ryankeairns
force-pushed
the
rk/base-web-styles
branch
from
5ac3b57 to
2252965
Compare
|
@smith figured out the profile dropdown, I think this is ready! |
|
@delivery approve |
|
Failed to approve change: b9f0fd67-16d6-4a1a-97d4-513280b7f7fb |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the first go at adding some global UI styles based upon current mockups. This stuff is not vetted as it will change once we get the Mortar branding guidelines at the end of April... but because that leaves us very little time I've gone ahead and started tidying up the HTML, adding in Sass variables for color/typography, etc., so that the end push is not as daunting.