Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for GitHub user login #350

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Preparation for GitHub user login #350

merged 1 commit into from
Apr 6, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Apr 6, 2016

  • Add authorization for some pages that redirects to sign in page when not
    signed in
  • Show/hide side bar items based on whether or not you're signed in
  • Remove the HomeComponent and just have / redirect to /pkgs
  • Add a reset middleware that resets the entire app state when signing
    out
  • Make the usernav component take parameters instead of relying on the
    AppStore
  • Put the current user info at users.current instead of user in the
    state
  • Get rid of the sign up form and only use the sign in form

* Add authorization for some pages that redirects to sign in page when not
  signed in
* Show/hide side bar items based on whether or not you're signed in
* Remove the HomeComponent and just have / redirect to /pkgs
* Add a reset middleware that resets the entire app state when signing
  out
* Make the usernav component take parameters instead of relying on the
  AppStore
* Put the current user info at users.current instead of user in the
  state
* Get rid of the sign up form and only use the sign in form
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@reset
Copy link
Collaborator

reset commented Apr 6, 2016

@smith solid work man, looks good!

gif-keyboard-6210458483841231807

@delivery approve

@chef-delivery chef-delivery merged commit c799813 into master Apr 6, 2016
@chef-delivery chef-delivery deleted the nls/gh branch April 6, 2016 19:55
@chef-delivery
Copy link
Contributor

Change: 7e9e6718-810b-4b5b-8e94-f881e9f21775 approved by: @reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants