Dashes should be replaced with underscores #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashes are not valid in environment variables. We allow them in the names of packages, so this will simply replace them with underscores, so shell things work as one would expect.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
This is looking good to me, although I suspect I'll need to try 'er out. In the meantime I don't think it makes anything worse off so, LGTM |
|
@delivery approve |
|
Change: ec1246ea-c311-4d4e-9467-207cb4251f09 approved by: @fnichol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashes are not valid in environment variables. We allow them in the
names of packages, so this will simply replace them with underscores,
so shell things work as one would expect.