Fix failing tests #366
Merged
Fix failing tests #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has passed 'Verify' and is ready for review and approval! |
| } | ||
|
|
||
| // generate a single key | ||
| if let Err(e) = hcore::crypto::generate_origin_sig_key(test_key_name) { | ||
| panic!("Error generating keys {}", e) | ||
| panic!("Error generating keys, {}", e) |
|
nice! |
fnichol
force-pushed
the
fix-failing-test
branch
from
1aef215 to
ea63a9a
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
|
I rebased the comma removal proposed by Dave.
|
|
@delivery approve |
|
Change: add009c3-e791-4aaf-96de-4aa2867fcde3 approved by: @fnichol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves logic of key generation by first checking if the path given is a valid path to a file on disk, then creates the parent directory before attempting to generate the keyfile in it.
It also fixes the documentation tests by marking some code blocks in the crypto module which were added as
textinstead of the default ofrust. These example blocks were trying to get compiled ;)