Replace GPG with NaCl #373
Conversation
|
This PR has passed 'Verify' and is ready for review and approval! |
bookshelfdave
force-pushed
the
dp_artifact_nacl
branch
from
511f94a to
c8b6d15
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
bookshelfdave
force-pushed
the
dp_artifact_nacl
branch
from
8ef3302 to
49588a6
Compare
|
This PR has passed 'Verify' and is ready for review and approval! |
| @@ -187,9 +187,9 @@ fn nacl_key_dir() -> String { | |||
|
|
|||
| /// Calculate the BLAKE2b hash of a file | |||
| /// NOTE: the key is empty | |||
| pub fn hash_file(filename: &str) -> Result<String> { | |||
| pub fn hash_file<P: AsRef<Path>>(filename: &P) -> Result<String> { | |||
|
This PR has passed 'Verify' and is ready for review and approval! |
| GenerateServiceKey, | ||
| ListKeys, | ||
| Encrypt, | ||
| Decrypt, |
| @@ -193,7 +193,7 @@ pub fn spawn(mut command: Command) -> CmdResult<Cmd> { | |||
| } | |||
|
|
|||
| pub fn studio_run(cmd: &str, args: &[&str]) -> CmdResult<Cmd> { | |||
| let real_cmd = "hab-studio"; | |||
| let real_cmd = "/src/components/studio/bin/hab-studio.sh"; | |||
There was a problem hiding this comment.
We'll want to keep hab-studio as the command to execute, meaning that the chef/hab-studio is required for functions. Or this happens in a Studio already, can't remember. This is fine for the moment though.
|
@metadave great pull request. You caught a lot of things that would be easily missed in this refactor and it's great to see how far your Rust knowledge has improved in only the last month! My only suggestion is just stylistic in nature: I would recommend avoiding multi-line comments. It can be the source of some headaches when you need to merge/rebase when those are being used. The comments in general are awesome. I like to follow the "TODO {initials}: {msg}" pattern also. It helps us remember what our goals are and that this is still a work in progress 😄. Merge when ready! |
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
|
Change: 82488ca5-3965-435a-a1d9-99a965866b0d approved by: @metadave |
Merged change 82488ca5-3965-435a-a1d9-99a965866b0d From review branch dp_artifact_nacl into master Signed-off-by: dparfitt <[email protected]>
hab-plan-build.shhas lots of TODO's, but it works."it compiles", tests fail, you'll need to be a Habitat bootstrap expert to get this rolling.