-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate user + service box keys #380
Conversation
this also reverts the generate origin key command back to: hab origin key generate <foo>
Ok(keyname) | ||
} | ||
|
||
// generate a service box key, return the name of the key we generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A double slash is for code comments and a triple slash is for documentation. Since this is a public function I'm assuming you wanted this to show up in the documentation so you would want to add one more slash. If you didn't want it to show up in the docs then this is how you do it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed.
This PR has passed 'Verify' and is ready for review and approval! |
@metadave super clean |
TODO:
|
This PR has passed 'Verify' and is ready for review and approval! |
4689de9
to
af847d8
Compare
af847d8
to
f0645b5
Compare
This PR has passed 'Verify' and is ready for review and approval! |
I thought I remembered seeing we were using the |
I was trying to stay consistent starting from https://github.com/chef/bldr/blob/master/components/hab/src/main.rs#L41 we can change it to whatever, as long as we are consistent across the board. |
env vars renamed to |
This PR has passed 'Verify' and is ready for review and approval! |
@delivery approve |
Change: 07c843fb-9336-462c-a336-a66616553363 approved by: @metadave |
This PR adds the following commands to generate keys:
.+\\..+
hab origin key generate
looks to have been reverted tohab origin generate_key
, so this PR fixes that.