key revisions are now calculated from existing public AND secret key files #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookshelfdave
changed the title
bookshelfdave
changed the title
|
This PR has passed 'Verify' and is ready for review and approval! |
|
Nice, will be even more convenient for Plan builds!
|
|
@delivery approve |
|
Change: 39bf3cbf-f365-4724-ab0f-782c95394e70 approved by: @fnichol |
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Merged change 39bf3cbf-f365-4724-ab0f-782c95394e70 From review branch dp_key_revision_bug into master Signed-off-by: fnichol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug forced an artifact signer to have both the secret
.sig.keyas well as the.pubkey in the key cache.