Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up initial Delivery acceptance environment #4

Merged
merged 1 commit into from
Oct 28, 2015

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Oct 5, 2015

No description provided.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

1 similar comment
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

There is currently a requirement for a more modern Ubuntu release to
support modern Docker and Docker Compose versions--in this case Ubuntu
15.04 build nodes.

The strategy is to, as closely as possible, match the developer flow of
running unit and functional tests. This means running these inside
Docker containers.
@fnichol fnichol force-pushed the delivery-acceptance branch from 369b3ab to 1352edb Compare October 28, 2015 21:57
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@fnichol fnichol changed the title [WIP] Set up initial Delivery acceptance environment Set up initial Delivery acceptance environment Oct 28, 2015
@fnichol
Copy link
Collaborator Author

fnichol commented Oct 28, 2015

Ready for review, finally!

@reset
Copy link
Collaborator

reset commented Oct 28, 2015

@delivery approve

chef-delivery added a commit that referenced this pull request Oct 28, 2015
Merged change 3fe949d8-1e18-43be-a360-eca515cc4b68

From review branch delivery-acceptance into master

Signed-off-by: reset <[email protected]>
@chef-delivery chef-delivery merged commit 8454ac1 into master Oct 28, 2015
@chef-delivery chef-delivery deleted the delivery-acceptance branch October 28, 2015 22:48
@chef-delivery
Copy link
Contributor

Change: 3fe949d8-1e18-43be-a360-eca515cc4b68 approved by: @reset

kagarmoe pushed a commit that referenced this pull request Jul 14, 2020
Signed-off-by: kagarmoe <[email protected]>
kagarmoe pushed a commit that referenced this pull request Aug 17, 2020
Signed-off-by: kagarmoe <[email protected]>
kagarmoe pushed a commit that referenced this pull request Aug 25, 2020
Signed-off-by: kagarmoe <[email protected]>
kagarmoe pushed a commit that referenced this pull request Aug 26, 2020
Signed-off-by: kagarmoe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants