tune loglevel of messages in depot and handle db full errors #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has passed 'Verify' and is ready for review and approval! |
| error!("Database full, err={:?}", e); | ||
| return Ok(Response::with(status::InsufficientStorage)); | ||
| } | ||
| Err(e) => panic!("Unhandled database error on upload, err={:?}", e), |
There was a problem hiding this comment.
This should probably return an Ok(Response::with(status::InternalServerError)) rather than a panic, otherwise the client side may just get a dropped connection when the request thread panics.
There was a problem hiding this comment.
The router's chain will always return a 500 to the client if you panic in a handler
|
@delivery approve |
|
Change: 76944206-d034-4e9e-8447-f6b346b0719b approved by: @reset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set the log level of messages to an appropriate level for running this service in production. I also have fixed one of the TODOs to handle database full messages on upload