Adding styles to new views #423
Conversation
| [route]="state.router.route"></hab-side-nav> | ||
| <section class="hab-main"> | ||
| [route]="state.router.route" | ||
| *ngIf="!hideNavCheck()"></hab-side-nav> |
There was a problem hiding this comment.
I don't think you need this to be a function. *ngIf="hideNav" should work, and the function definition is not needed.
There was a problem hiding this comment.
Sweet, that worked perfectly - much simpler!
ryankeairns
force-pushed
the
rk/applying-moar-design
branch
from
5ed43a4 to
4312b3d
Compare
| @@ -162,6 +163,11 @@ export class AppComponent implements OnInit { | |||
| // route data. | |||
| router.subscribe(value => store.dispatch(routeChange(value))); | |||
There was a problem hiding this comment.
Can you combine these two together to be:
router.subscribe(value => {
this.hideNav = value === "sign-in";
store.dispatch(routeChange(value)));
});There was a problem hiding this comment.
I've poked at this a few times and can't quite get it right... ok if we push it to a follow-up PR so that I can get all this UI work merged?
There was a problem hiding this comment.
Ok, but not sure I understand what the problem is. Are you getting some kind of error using the code I put in the comment above?
There was a problem hiding this comment.
Figured it out with a clearer head this morning... I had a couple of issues going on (lint error, needed to declare the hideNav variable, added if statement since return url now has params on it, etc.)
Speaking of the redirect url, it seems unexpected to return to the sign in/sign out screen... I would prefer they return to their Projects. Is that as simple as changing the redirect URL on github?
Thanks for the feedback on this!
|
There's a couple things on the sign in page: Note that the shaded border on the bottom appears twice. I made the sign out button the same width as the sign in button but it looks like that got broke. |
|
@ryankeairns you'll need to rebase this guy! |
|
Making good progress catching up to @smith's latest work. I'll rebase in the morning and aim to get this merged tomorrow. |
ryankeairns
force-pushed
the
rk/applying-moar-design
branch
from
3f059e3 to
825572c
Compare
|
👍 looks great. Merge after the lint fixes and removing that unnecessary if statement.
|
|
|
* sign-up styles and alternative layout * styles on projects, forms, sign-in, misc global * remove hideNavCheck function * styles for switch, repo select, orgs, notfiications, add forms, etc * consolidate router subscribe statements * resolve linting, update logo * remove hideNav if statement
Going through and tidying up layouts and styles:
Note: I did some angular hacking in the AppComponent to remove the side nav from the sign-in view... I wanted to keep this particular screen solely focused on the act of signing in since this is a key metric we'd like to track (# of sign-ups).