Habitat Artifact and Origin Key Header Update #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this will invalidate all previously build artifacts. This change adds a simple lexically sortable version string on the first plaintext line of the artifact. It additionally adds a blank line bewteen the header/prelude and the data binary stream. In other words external tooling could opt to check for the first blank line or 2 newline characters as the delimiter.
fnichol
force-pushed
the
fnichol/hart-and-origin-headers
branch
from
f9dd08f to
3c8e234
Compare
fnichol
force-pushed
the
fnichol/hart-and-origin-headers
branch
from
3c8e234 to
b1ec1c4
Compare
| debug!("Your key name = [{}]", your_key_name); | ||
| debug!("Your hash type = [{}]", your_hash_type); | ||
| debug!("Your signature = [{}]", your_signature_raw); | ||
|
|
||
| if your_format_version.trim() != HART_FORMAT_VERSION { | ||
| let msg = format!("Unsupported format version: {}. Supported format versions: [{}]", |
fnichol
changed the title
|
|
fnichol
added a commit
that referenced
this pull request
Apr 23, 2016
Due the changes in #425, the header portion of a Habitat Artifact has grown from the first 3 lines to 5 lines, the last of which is an empty line. In order for the "cheap" (i.e. dirty, evil, not recommended) install method that `hab-bpm` currently uses to work, we need to start reading the tar archive starting on line 6 now, not 4. Hm, the commit message is far longer than the fix. Funny how that works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on to work in #424 and should be merged afterwards.