Convert Depot data storage to Redis #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset
force-pushed
the
redis-depot
branch
4 times, most recently
from
1e4c983 to
3aedd45
Compare
|
I built a package from this and successfully uploaded an entire stage1 set of artifacts. Then used that to launch a default type Studio (which installs from packages). I pushed a commit which updates 2 Cargo.lock files, but otherwise we're going to be good to merge here shortly. |
|
|
|
|
| path: "/hab/svc/hab-depot/data".to_string(), | ||
| port: super::ListenPort::default(), | ||
| listen_addr: super::ListenAddr::default(), | ||
| datastore_addr: net::SocketAddrV4::new(net::Ipv4Addr::new(127, 0, 0, 1), 6379), |
There was a problem hiding this comment.
We'll want to make this configurable but can handle that in a later PR.
There was a problem hiding this comment.
Gonna be taking care of this now in another PR since I already need it to deploy the service ;)
|
excellent!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the backend of the Depot's DataStore from LMDB to Redis. I've added some abstractions in the
dbcachecrate which are not complete but will be molded as we continue to build out our persistence layer in the vault. The Depot doesn't store data the way the Vault server does, so we're only using the most basic abstractions.The behaviour of the API should be completely unchanged with the exception of one addition. You can now list all packages of a given origin within a view. I'm not sure if we need this but it was easy to add so I just went ahead and did it.
The doctor tool is a little less feature-ful than it was before, but it also was never exactly complete. Right now it will blow away any views you have created and any packages you have assigned to them on repair. I'll need to add these features back in when I revisit it.