Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency, linting, and compression updates #437

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Dependency, linting, and compression updates #437

merged 1 commit into from
Apr 25, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Apr 25, 2016

  • Update angular2 to latest beta
  • Update typings to latest
  • Compress JS and CSS
  • Update CSS linting config
  • Remove some CSS lint violations
  • Enable prod mode when config["environment"] === "production"
  • Move /app/assets to /assets and make them work in the dist

* Update angular2 to latest beta
* Update typings to latest
* Compress JS and CSS
* Update CSS linting config
* Remove some CSS lint violations
* Enable prod mode when `config["environment"] === "production"`
* Move /app/assets to /assets and make them work in the dist
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @ryankeairns, @fnichol and @jtimberman to be potential reviewers

@reset
Copy link
Collaborator

reset commented Apr 25, 2016

gif-keyboard-5094307185463868012

@reset reset merged commit 0e03155 into master Apr 25, 2016
@reset reset deleted the nls/compress branch April 25, 2016 18:46
smith pushed a commit that referenced this pull request Apr 25, 2016
Make it so when we `npm run dist`, it takes a SHA256 of app.js and
app.css and uses those filenames in the built code. This means we can
cache these files forever and users won't have to bust the cache.

Also:

* Fix some CSS and JS linting issues
* Split the long npm scripts into separate script files
* Shrinkwrap the stuff that was added in #437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants