Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore habitat secret key files #446

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Conversation

bookshelfdave
Copy link
Contributor

Just a safety measure so we don't accidentally add any secret Habitat keys to the repo.

Key suffixes defined here: https://github.com/habitat-sh/habitat/blob/master/components/core/src/crypto.rs#L223-L230

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @reset and @fnichol to be potential reviewers

@adamhjk
Copy link
Contributor

adamhjk commented Apr 26, 2016

gif-keyboard-7407940528191878061

@adamhjk
Copy link
Contributor

adamhjk commented Apr 26, 2016

r+

@adamhjk
Copy link
Contributor

adamhjk commented Apr 26, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 8f63a66 has been approved by adamhjk

@thesentinels
Copy link
Contributor

⌛ Testing commit 8f63a66 with merge 4569bc9...

thesentinels pushed a commit that referenced this pull request Apr 26, 2016
Pull request: #446
Approved by: adamhjk
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 8f63a66 into master Apr 26, 2016
@reset reset deleted the dp_ignore_secret_keys branch April 27, 2016 18:27
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Pull request: #446
Approved by: adamhjk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants