add ParseInto trait for parsing config fields into rust types #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @fnichol, @adamhjk, @metadave and @davidwrede to be potential reviewers |
|
|
|
📌 Commit df2ac73 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Apr 27, 2016
Pull request: #454 Approved by: adamhjk
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Pull request: #454 Approved by: adamhjk
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Pull request: #454 Approved by: adamhjk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to easily parse common fields into their actual Rust types and provide the user with explicit error messages on failures