Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure builder servers from file #456

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Configure builder servers from file #456

merged 1 commit into from
Apr 28, 2016

Conversation

reset
Copy link
Collaborator

@reset reset commented Apr 28, 2016

  • sessionsrv, builder-api, and vault all configurable by file
  • Retrieve detailed version from plan for builder services
  • Move plans to a more appropriate location for builder services
  • Remove config template from builder services plan's

gif-keyboard-17985379983896804580

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @fnichol to be a potential reviewer

* sessionsrv, builder-api, and vault all configurable by file
* Retrieve detailed version from plan for builder services
* Move plans to a more appropriate location for builder services
* Remove config template from builder services plan's
@reset
Copy link
Collaborator Author

reset commented Apr 28, 2016

@habitat-sh/habitat-core-maintainers this is good to go

@bookshelfdave
Copy link
Contributor

gif-keyboard-14613457690254079850

@bookshelfdave
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit c080861 has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit c080861 with merge 63816dd...

thesentinels pushed a commit that referenced this pull request Apr 28, 2016
* sessionsrv, builder-api, and vault all configurable by file
* Retrieve detailed version from plan for builder services
* Move plans to a more appropriate location for builder services
* Remove config template from builder services plan's

Pull request: #456
Approved by: metadave
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit c080861 into master Apr 28, 2016
@reset reset deleted the configure-file branch April 28, 2016 17:17
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
* sessionsrv, builder-api, and vault all configurable by file
* Retrieve detailed version from plan for builder services
* Move plans to a more appropriate location for builder services
* Remove config template from builder services plan's

Pull request: #456
Approved by: metadave
raskchanky pushed a commit that referenced this pull request Apr 16, 2019
* sessionsrv, builder-api, and vault all configurable by file
* Retrieve detailed version from plan for builder services
* Move plans to a more appropriate location for builder services
* Remove config template from builder services plan's

Pull request: #456
Approved by: metadave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants