-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install core origin public key in devshell and Studios #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary measure until public origin keys are downloaded on package installations. Its implementation is non-straight forward because we're caching the `/hab/cache/keys` directory with a mounted data volume. When the Docker container comes up, this directory is bind mounted over and the underlying directory contents is masked out.
By analyzing the blame information on this pull request, we identified @reset, @metadave, @jtimberman and @adamhjk to be potential reviewers |
This is a temporary measure until public keys are downloaded on package installations.
📌 Commit 902d259 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Apr 28, 2016
This is a temporary measure until public origin keys are downloaded on package installations. Its implementation is non-straight forward because we're caching the `/hab/cache/keys` directory with a mounted data volume. When the Docker container comes up, this directory is bind mounted over and the underlying directory contents is masked out. Pull request: #457 Approved by: reset
thesentinels
pushed a commit
that referenced
this pull request
Apr 28, 2016
This is a temporary measure until public keys are downloaded on package installations. Pull request: #457 Approved by: reset
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This is a temporary measure until public origin keys are downloaded on package installations. Its implementation is non-straight forward because we're caching the `/hab/cache/keys` directory with a mounted data volume. When the Docker container comes up, this directory is bind mounted over and the underlying directory contents is masked out. Pull request: #457 Approved by: reset
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This is a temporary measure until public keys are downloaded on package installations. Pull request: #457 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary measure until public origin keys are downloaded on
package installations. Its implementation is non-straight forward
because we're caching the
/hab/cache/keys
directory with a mounteddata volume. When the Docker container comes up, this directory is bind
mounted over and the underlying directory contents is masked out.