Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install core origin public key in devshell and Studios #457

Merged
merged 2 commits into from
Apr 28, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Apr 28, 2016

This is a temporary measure until public origin keys are downloaded on
package installations. Its implementation is non-straight forward
because we're caching the /hab/cache/keys directory with a mounted
data volume. When the Docker container comes up, this directory is bind
mounted over and the underlying directory contents is masked out.

This is a temporary measure until public origin keys are downloaded on
package installations. Its implementation is non-straight forward
because we're caching the `/hab/cache/keys` directory with a mounted
data volume. When the Docker container comes up, this directory is bind
mounted over and the underlying directory contents is masked out.
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @reset, @metadave, @jtimberman and @adamhjk to be potential reviewers

This is a temporary measure until public keys are downloaded on package
installations.
@fnichol fnichol changed the title [WIP] Install core origin public key in devshell. Install core origin public key in devshell and Studios Apr 28, 2016
@fnichol
Copy link
Collaborator Author

fnichol commented Apr 28, 2016

This one is ready for review!

gif-keyboard-15460606526109696024

@reset
Copy link
Collaborator

reset commented Apr 28, 2016

gif-keyboard-1651790552354105876

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 902d259 has been approved by reset

@thesentinels
Copy link
Contributor

⌛ Testing commit 902d259 with merge e74782f...

thesentinels pushed a commit that referenced this pull request Apr 28, 2016
This is a temporary measure until public origin keys are downloaded on
package installations. Its implementation is non-straight forward
because we're caching the `/hab/cache/keys` directory with a mounted
data volume. When the Docker container comes up, this directory is bind
mounted over and the underlying directory contents is masked out.

Pull request: #457
Approved by: reset
thesentinels pushed a commit that referenced this pull request Apr 28, 2016
This is a temporary measure until public keys are downloaded on package
installations.

Pull request: #457
Approved by: reset
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 902d259 into master Apr 28, 2016
@fnichol fnichol deleted the fnichol/pub-key-bandaid branch April 28, 2016 14:10
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
This is a temporary measure until public origin keys are downloaded on
package installations. Its implementation is non-straight forward
because we're caching the `/hab/cache/keys` directory with a mounted
data volume. When the Docker container comes up, this directory is bind
mounted over and the underlying directory contents is masked out.

Pull request: #457
Approved by: reset
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
This is a temporary measure until public keys are downloaded on package
installations.

Pull request: #457
Approved by: reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants