Add support for http_proxy & https_proxy.
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fnichol
force-pushed
the
http-proxy
branch
2 times, most recently
from
bd77341 to
938ccbd
Compare
This change transmits the lowercase HTTP proxy environment variables into the following places: * In `docker build` in the Makefile (using the new `--build-arg` flag in Docker 1.9) * In `docker-compose.yml` by adding `envrionment` blocks. In both cases, if one or neither of the variables are set, empty values are passed in and nothing should happen.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 11, 2015
Merged change 3ad693fd-5a8b-49b7-bd52-87f7c0f337f9 From review branch http-proxy into master Signed-off-by: reset <[email protected]>
|
Change: 3ad693fd-5a8b-49b7-bd52-87f7c0f337f9 approved by: @reset |
|
|
|
@adamhjk I am reliving this entire movie now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change transmits the lowercase HTTP proxy environment variables
into the following places:
docker buildin the Makefile (using the new--build-argflag inDocker 1.9)
docker-compose.ymlby addingenvrionmentblocks.In both cases, if one or neither of the variables are set, empty values
are passed in and nothing should happen.