[devshell] Prevent the protobuf crate binary from being mount-masked.
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue we had in the devshell when trying to build all components. The `cargo install protobuf` command in the Dockerfile honors the `$CARGO_HOME` environment variable override (as it should), but that directory get overlay-mounted whenever a container is started up which means that our lovingly compiled binaries get masked over. Instead, we'll install this crate into the default location (under root's home) and add that path to the environment's `$PATH`. Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @reset, @metadave, @jtimberman and @adamhjk to be potential reviewers |
|
📌 Commit 0922e14 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Apr 29, 2016
This change fixes an issue we had in the devshell when trying to build all components. The `cargo install protobuf` command in the Dockerfile honors the `$CARGO_HOME` environment variable override (as it should), but that directory get overlay-mounted whenever a container is started up which means that our lovingly compiled binaries get masked over. Instead, we'll install this crate into the default location (under root's home) and add that path to the environment's `$PATH`. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #467 Approved by: adamhjk
|
☀️ Test successful - travis |
smith
pushed a commit
that referenced
this pull request
May 2, 2016
This change fixes an issue we had in the devshell when trying to build all components. The `cargo install protobuf` command in the Dockerfile honors the `$CARGO_HOME` environment variable override (as it should), but that directory get overlay-mounted whenever a container is started up which means that our lovingly compiled binaries get masked over. Instead, we'll install this crate into the default location (under root's home) and add that path to the environment's `$PATH`. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #467 Approved by: adamhjk
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change fixes an issue we had in the devshell when trying to build all components. The `cargo install protobuf` command in the Dockerfile honors the `$CARGO_HOME` environment variable override (as it should), but that directory get overlay-mounted whenever a container is started up which means that our lovingly compiled binaries get masked over. Instead, we'll install this crate into the default location (under root's home) and add that path to the environment's `$PATH`. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #467 Approved by: adamhjk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue we had in the devshell when trying to build
all components. The
cargo install protobufcommand in the Dockerfilehonors the
$CARGO_HOMEenvironment variable override (as it should),but that directory get overlay-mounted whenever a container is started
up which means that our lovingly compiled binaries get masked over.
Instead, we'll install this crate into the default location (under
root's home) and add that path to the environment's
$PATH.Signed-off-by: Fletcher Nichol [email protected]