Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update crypto module documentation, suitable for rustdocs. #469

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Apr 29, 2016

This change allows us to view the crypto code documentation via cargo doc. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol [email protected]

This change allows us to view the crypto code documentation via `cargo
doc`. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol <[email protected]>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @metadave and @reset to be potential reviewers

/// *******************************************
// *******************************************
// Key generation functions
// *******************************************
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 to 2 slash commenting style change is to avoid this internal comment from being rendered as the function documentation in the next function.

@bookshelfdave
Copy link
Contributor

gif-keyboard-2041757031157211849

@bookshelfdave
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit c143b40 has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit c143b40 with merge c86dfab...

thesentinels pushed a commit that referenced this pull request Apr 29, 2016
This change allows us to view the crypto code documentation via `cargo
doc`. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #469
Approved by: metadave
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit c143b40 into master Apr 29, 2016
smith pushed a commit that referenced this pull request May 2, 2016
This change allows us to view the crypto code documentation via `cargo
doc`. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #469
Approved by: metadave
@fnichol fnichol deleted the fnichol/update-crypto-code-docs branch June 10, 2016 04:20
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
This change allows us to view the crypto code documentation via `cargo
doc`. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #469
Approved by: metadave
raskchanky pushed a commit that referenced this pull request Apr 16, 2019
This change allows us to view the crypto code documentation via `cargo
doc`. Some of the section heading are moved around to keep similar
concepts together and for markdown formatting.

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #469
Approved by: metadave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants