Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cli output to Try Habitat feature #483

Merged
merged 2 commits into from
May 5, 2016
Merged

Conversation

ryankeairns
Copy link
Contributor

With things taking shape, I was able to run all of the commands (except -strategy and -bind) and get the actual output into the steps. This commit also adds some tab-style buttons to switch between terminal windows on a couple of steps and add a back link to view previous step.

Ryan Keairns added 2 commits May 4, 2016 16:30
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps to be a potential reviewer

@ryankeairns
Copy link
Contributor Author

@smith @juliandunn this is the PR for Try Hab content. Let me know what you think, thanks!

@cwebberOps
Copy link
Contributor

@magwalk you may have thoughts... can you please take a look at the styling.

@juliandunn
Copy link
Contributor

@ryankeairns you decided not to go with core/postgresql for the config injection? it's fine, just want to know if there was a reason for that.

Otherwise, 👍 and if @magwalk has no comments by tomorrow I'll r+ this

@ryankeairns
Copy link
Contributor Author

@juliandunn I started with redis originally throughout (weeks ago), switched to postgresql when we were going down the road of setting up an app (as the example), then switched back to redis when we changed course to this new feature overview approach.

The other reason is that I was getting permission errors with postgresql, whereas redis worked reliably. I'm not as familiar with the added benefit of one over the other (as it pertains to our audience), but if you think it's worth the effort then I'll make the switch (~ 1 day worth of work).

@juliandunn
Copy link
Contributor

@ryankeairns nah let's just go with this for now to get the "Try Habitat" experience out there. I can help you debug core/postgresql later if we want.

@juliandunn
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 5d1503c has been approved by juliandunn

@thesentinels
Copy link
Contributor

⌛ Testing commit 5d1503c with merge eb34db8...

thesentinels pushed a commit that referenced this pull request May 5, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #483
Approved by: juliandunn
thesentinels pushed a commit that referenced this pull request May 5, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #483
Approved by: juliandunn
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 5d1503c into master May 5, 2016
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #483
Approved by: juliandunn
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Signed-off-by: Ryan Keairns <[email protected]>

Pull request: #483
Approved by: juliandunn
@smurawski smurawski deleted the rk/try-it-youll-like-it branch February 3, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants