sidecar + gossip can listen to a custom ip:port #499
Conversation
|
By analyzing the blame information on this pull request, we identified @adamhjk, @reset, @fnichol, @juliandunn and @jtimberman to be potential reviewers |
`hab-sup start` behavior is as follows:
- without `--listen-peer`
- gossip starts on `util::sys::ip()` : `DEFAULT_GOSSIP_LISTEN_PORT`
- with `--listen-peer` IP without port
- gossip starts on `IP:GOSSIP_DEFAULT_PORT`
- with `--listen-peer` IP:PORT
- gossip starts on `IP:PORT`
- remove rpassword dep, it was used with GPG
Signed-off-by: Dave Parfitt <[email protected]>
bookshelfdave
force-pushed
the
dp_config_ports
branch
from
6a803e5 to
52872b9
Compare
Signed-off-by: Dave Parfitt <[email protected]>
bookshelfdave
force-pushed
the
dp_config_ports
branch
from
acd79f6 to
60d83c7
Compare
|
This is pure noodling, but is v6 support just a couple of functions away? I haven't even looked. My guess is that it is. |
|
@adamhjk I think so, it looks like utp supports IPv6 and we have |
|
I think we take this as it is, and we should think about expanding all our bindings/references everywhere to work with v6 as well as v4. Agree? |
|
(we can do that later - someone will request it eventually :) |
|
+1, I'd love to see IPv6
|
|
📌 Commit 60d83c7 has been approved by |
`hab-sup start` behavior is as follows:
- without `--listen-peer`
- gossip starts on `util::sys::ip()` : `DEFAULT_GOSSIP_LISTEN_PORT`
- with `--listen-peer` IP without port
- gossip starts on `IP:GOSSIP_DEFAULT_PORT`
- with `--listen-peer` IP:PORT
- gossip starts on `IP:PORT`
- remove rpassword dep, it was used with GPG
Signed-off-by: Dave Parfitt <[email protected]>
Pull request: #499
Approved by: adamhjk
Signed-off-by: Dave Parfitt <[email protected]> Pull request: #499 Approved by: adamhjk
|
☀️ Test successful - travis |
`hab-sup start` behavior is as follows:
- without `--listen-peer`
- gossip starts on `util::sys::ip()` : `DEFAULT_GOSSIP_LISTEN_PORT`
- with `--listen-peer` IP without port
- gossip starts on `IP:GOSSIP_DEFAULT_PORT`
- with `--listen-peer` IP:PORT
- gossip starts on `IP:PORT`
- remove rpassword dep, it was used with GPG
Signed-off-by: Dave Parfitt <[email protected]>
Pull request: #499
Approved by: adamhjk
Signed-off-by: Dave Parfitt <[email protected]> Pull request: #499 Approved by: adamhjk
hab-sup startbehavior is as follows:--listen-peerutil::sys::ip():DEFAULT_GOSSIP_LISTEN_PORT--listen-peerIP without portDEFAULT_GOSSIP_LISTEN_PORT--listen-peerIP:PORTIP:PORTMisc: