Release 0.5.0, with more Habitats for all services. #504
Conversation
|
By analyzing the blame information on this pull request, we identified @reset, @jtimberman, @metadave, @adamhjk and @smith to be potential reviewers |
| dependencies = [ | ||
| "bitflags 0.5.0 (registry+https://github.com/rust-lang/crates.io-index)", | ||
| "bitflags 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)", |
There was a problem hiding this comment.
What is this? Why did we downgrade?
There was a problem hiding this comment.
@fnichol I wouldn't be worried about this mainly because builder-protocol doesn't even required bitflags anymore, I just haven't removed it as a dep
|
It seems there's some disagreement in the |
|
@jtimberman I'm not 100% why one or two of the bitflags deps bumped down, but I suspect it's related to the |
|
I think we should figure out how to stay in sync across the board (since I'm a believer in break early, not brake late, we should be taking upstream versions frequently.) That said, for sure we can have different versions in components that don't compile together - so it won't be blocking the product from working. |
|
@jtimberman I know that a) the dependency chain in Cargo is slightly different than other tooling as each native crate is statically built, thus slurping in its dependencies, and b) Cargo is less battle tested than Bundler and gang so occasionally dep solving leads to surprising answers. |
|
@adamhjk If we need to do this manually, even for the short term, I'd propose we want to "chore" this as a once-a-week recurring item. |
|
@fnichol the generated protocol files are just fine. This is becuase you generated them with a newer version of the protobuf-rust plugin than I did. I should upgrade. I've got some changes in a branch I'm working on that I might split out to help ease this confusion. Right now we are generating protocol files on every build of any crate that is, or depends on, builder-protocol. This adds unnecessary times to our local build and interferes with racer/linter integrations into your editor. I've added a feature flag to the protocols project that will only generate protocols if you pass |
|
|
|
@reset I'm starting to like the |
|
@fnichol funny thing is that I was hugely aggravated in a previous project when the protocol files didn't automatically build. Now I understand why they did that... |
|
📌 Commit f43800e has been approved by |
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #504 Approved by: fnichol
|
☀️ Test successful - travis |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Signed-off-by: Fletcher Nichol <[email protected]>
|
📌 Commit 07ec998 has been approved by |
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #504 Approved by: fnichol
|
☀️ Test successful - travis |
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #504 Approved by: fnichol
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #504 Approved by: fnichol
No description provided.