Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Google Analytics snippet to website #511

Merged
merged 2 commits into from
May 12, 2016
Merged

Conversation

ryankeairns
Copy link
Contributor

Technically, we're trying Google Tag Manager which is an alternative implementation of Google Analytics that allows us to manage events remotely/dynamically with very minimal code changes.

Ryan Keairns added 2 commits May 11, 2016 22:32
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @cwebberOps to be a potential reviewer

@ryankeairns
Copy link
Contributor Author

@smith @magwalk can I get some 👀 on this... its really small, just adding the Google Analytics snippet.

Side note, we're trying out Google Tag Manager which allows non-developers to add/track events remotely without having a developer push a change on the markup. Once this gets merged, we'll be able to see if these events are firing on the EA release of the website.

Thanks!

@cwebberOps
Copy link
Contributor

@ryankeairns The snippet looks good to me... Before we do this we should get the demandbase snippet if needed just so it all gets added in one go.

@smith
Copy link
Contributor

smith commented May 12, 2016

LGTM.

@ryankeairns
Copy link
Contributor Author

I'm going to merge this so that I can verify it's working on the live site. I've created myself a to-do item for adding demandbase should we need it... that will only take a few minutes and small commit.

@ryankeairns ryankeairns merged commit 0019fee into master May 12, 2016
@ryankeairns ryankeairns deleted the somebodys-watchin-me branch May 12, 2016 15:23
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
* adding Googlt Tag Manager to site for analytics

Signed-off-by: Ryan Keairns <[email protected]>

* added the partial back

Signed-off-by: Ryan Keairns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants