Support http_proxy & no_proxy environment variables for Depot calls.
#512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this will help users in constrained network environments, I'm really excited about regaining the speed of locally caching artifacts with an http proxy instance.
|
fnichol
force-pushed
the
fnichol/depot-client-http-proxy
branch
2 times, most recently
from
55a169e to
385a167
Compare
|
☔ The latest upstream changes (presumably 0b12a73) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@fnichol super clean. Let's get the 0.5.0 commit out of this PR and merge it! |
This feature adds support for using the `http_proxy` and `no_proxy` environment variables when interacting with a Depot via the `depot-client` component which powers the `hab` CLI and the `hab-sup` Supervisor. The raw environment variable parsing and interpretation is maintained in the `core` component, which is then used by the `depot-client` when creating `hyper::Client` instances. If the Depot URL's host/domain part matches an entry in the `no_proxy` comma-separated list of domain extensions, a proxy will not be used. Note that at the moment the behavior when calling SSL-wrapped Depot instances is undefined and not tested (which will happen later when this is officially supported). Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
fnichol/depot-client-http-proxy
branch
from
385a167 to
705906a
Compare
|
📌 Commit 705906a has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 12, 2016
This feature adds support for using the `http_proxy` and `no_proxy` environment variables when interacting with a Depot via the `depot-client` component which powers the `hab` CLI and the `hab-sup` Supervisor. The raw environment variable parsing and interpretation is maintained in the `core` component, which is then used by the `depot-client` when creating `hyper::Client` instances. If the Depot URL's host/domain part matches an entry in the `no_proxy` comma-separated list of domain extensions, a proxy will not be used. Note that at the moment the behavior when calling SSL-wrapped Depot instances is undefined and not tested (which will happen later when this is officially supported). Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #512 Approved by: reset
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This feature adds support for using the `http_proxy` and `no_proxy` environment variables when interacting with a Depot via the `depot-client` component which powers the `hab` CLI and the `hab-sup` Supervisor. The raw environment variable parsing and interpretation is maintained in the `core` component, which is then used by the `depot-client` when creating `hyper::Client` instances. If the Depot URL's host/domain part matches an entry in the `no_proxy` comma-separated list of domain extensions, a proxy will not be used. Note that at the moment the behavior when calling SSL-wrapped Depot instances is undefined and not tested (which will happen later when this is officially supported). Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #512 Approved by: reset
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
This feature adds support for using the `http_proxy` and `no_proxy` environment variables when interacting with a Depot via the `depot-client` component which powers the `hab` CLI and the `hab-sup` Supervisor. The raw environment variable parsing and interpretation is maintained in the `core` component, which is then used by the `depot-client` when creating `hyper::Client` instances. If the Depot URL's host/domain part matches an entry in the `no_proxy` comma-separated list of domain extensions, a proxy will not be used. Note that at the moment the behavior when calling SSL-wrapped Depot instances is undefined and not tested (which will happen later when this is officially supported). Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #512 Approved by: reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds support for using the
http_proxyandno_proxyenvironment variables when interacting with a Depot via thedepot-clientcomponent which powers thehabCLI and thehab-supSupervisor.
The raw environment variable parsing and interpretation is maintained in
the
corecomponent, which is then used by thedepot-clientwhencreating
hyper::Clientinstances. If the Depot URL's host/domain partmatches an entry in the
no_proxycomma-separated list of domainextensions, a proxy will not be used. Note that at the moment the
behavior when calling SSL-wrapped Depot instances is undefined and not
tested (which will happen later when this is officially supported).
Signed-off-by: Fletcher Nichol [email protected]