Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plans] Add ttyrec plan. #514

Merged
merged 1 commit into from
May 13, 2016
Merged

[plans] Add ttyrec plan. #514

merged 1 commit into from
May 13, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented May 12, 2016

I have great and evil plans for this one ;)

gif-keyboard-612773166345216975

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

@reset
Copy link
Collaborator

reset commented May 12, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 4e2e2b7 has been approved by reset

@thesentinels
Copy link
Contributor

⌛ Testing commit 4e2e2b7 with merge d428183...

thesentinels pushed a commit that referenced this pull request May 12, 2016
I have great and evil plans for this one ;)

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #514
Approved by: reset
@thesentinels
Copy link
Contributor

💔 Test failed - travis

@fnichol fnichol force-pushed the fnichol/ttyrec-plan branch from 4e2e2b7 to 155fc91 Compare May 12, 2016 18:37
I have great and evil plans for this one ;)

Signed-off-by: Fletcher Nichol <[email protected]>
@fnichol fnichol force-pushed the fnichol/ttyrec-plan branch from 155fc91 to e411060 Compare May 12, 2016 20:25
@smith
Copy link
Contributor

smith commented May 13, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit e411060 has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit e411060 with merge 790ef4c...

thesentinels pushed a commit that referenced this pull request May 13, 2016
I have great and evil plans for this one ;)

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #514
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit e411060 into master May 13, 2016
@fnichol fnichol deleted the fnichol/ttyrec-plan branch June 10, 2016 04:20
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
I have great and evil plans for this one ;)

Signed-off-by: Fletcher Nichol <[email protected]>

Pull request: #514
Approved by: smith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants