Create plan for Elixir 1.2.5 #518
Conversation
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
@shanesveller if you give this one a rebase it should pass Travis now. Sorry for the trouble. |
|
@thesentinels retry |
|
@smith I think we might still be dying on decrypting that file |
|
@fnichol looks like you're right. Turns out I added that line to publish.sh (so it only runs when merged) but forgot to remove it from travis.yml. |
|
Ok, @shanesveller you can give this one another rebase and it should actually work this time. If you don't have time for that just let me know here and I can reopen this PR myself so you don't have to worry about it. |
Signed-off-by: Shane Sveller <[email protected]>
|
@thesentinels retry |
|
📌 Commit 7f14f19 has been approved by |
Signed-off-by: Shane Sveller <[email protected]> Pull request: #518 Approved by: smith
|
💔 Test failed - travis |
|
@thesentinels retry |
Signed-off-by: Shane Sveller <[email protected]> Pull request: #518 Approved by: smith
|
☀️ Test successful - travis |
Signed-off-by: Shane Sveller <[email protected]> Pull request: #518 Approved by: smith
Feedback desired around
pkg_maintainer, how to ensure I'm defining minimal viable dependencies except via trial and error, and how to persist/propogate env vars likeLC_ALLandLANGto downstream consumers of this artifact. Any other advice around best practices also very welcome.