-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to make builder-web navigation more real #524
Conversation
By analyzing the blame information on this pull request, we identified @ryankeairns and @reset to be potential reviewers |
@smith We're getting close. After we last chatted about this with Julian (re: removing switcher, etc.), I shared an updated wireframe with the new navigation. What you have here is really close, main difference being I just combined them into one short list with a single DASHBOARD heading: Here is the link - https://invis.io/NX63KE3K2#/136467718_Web_App_-_Projects_Empty So slightly re-arranging what you have it would become: DASHBOARD
Thanks! |
@ryankeairns thanks for linking that. I forgot about your wireframes and was just going with my gut. Will update based on those. |
@ryankeairns updated the nav to match the wireframes. |
@smith do you still need to push up the latest commit? |
@ryankeairns no I rebased and force-pushed |
@smith looks good |
Put the information presented to the user more in line with what the API is currently capable of. * Remove the "all packages" and "my packages" and just present "core" * Remove the origin switcher * Name the side nav items more consistently * Make /pkgs/core the default route * Redirect to / instead of /sign-in on sign in Signed-off-by: Nathan L Smith <[email protected]>
📌 Commit eed3daa has been approved by |
Put the information presented to the user more in line with what the API is currently capable of. * Remove the "all packages" and "my packages" and just present "core" * Remove the origin switcher * Name the side nav items more consistently * Make /pkgs/core the default route * Redirect to / instead of /sign-in on sign in Signed-off-by: Nathan L Smith <[email protected]> Pull request: #524 Approved by: smith
☀️ Test successful - travis |
Put the information presented to the user more in line with what the API is currently capable of. * Remove the "all packages" and "my packages" and just present "core" * Remove the origin switcher * Name the side nav items more consistently * Make /pkgs/core the default route * Redirect to / instead of /sign-in on sign in Signed-off-by: Nathan L Smith <[email protected]> Pull request: #524 Approved by: smith
Put the information presented to the user more in line with what the API
is currently capable of.