Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to make builder-web navigation more real #524

Merged
merged 1 commit into from
May 17, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented May 16, 2016

Put the information presented to the user more in line with what the API
is currently capable of.

  • Remove the "all packages" and "my packages" and just present "core"
  • Remove the origin switcher
  • Name the side nav items more consistently
  • Make /pkgs/core the default route
  • Redirect to / instead of /sign-in on sign in

giphy

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @ryankeairns and @reset to be potential reviewers

@ryankeairns
Copy link
Contributor

ryankeairns commented May 16, 2016

@smith We're getting close. After we last chatted about this with Julian (re: removing switcher, etc.), I shared an updated wireframe with the new navigation. What you have here is really close, main difference being I just combined them into one short list with a single DASHBOARD heading:

Here is the link - https://invis.io/NX63KE3K2#/136467718_Web_App_-_Projects_Empty

So slightly re-arranging what you have it would become:

DASHBOARD

  • Projects
  • Origins
  • Organizations
  • Public Packages (or Core Packages if you think that makes more sense)

Thanks!

@smith
Copy link
Contributor Author

smith commented May 16, 2016

@ryankeairns thanks for linking that. I forgot about your wireframes and was just going with my gut. Will update based on those.

@smith
Copy link
Contributor Author

smith commented May 16, 2016

@ryankeairns updated the nav to match the wireframes.

@ryankeairns
Copy link
Contributor

@smith do you still need to push up the latest commit?

@smith
Copy link
Contributor Author

smith commented May 16, 2016

@ryankeairns no I rebased and force-pushed

@ryankeairns
Copy link
Contributor

ryankeairns commented May 16, 2016

@smith looks good

Put the information presented to the user more in line with what the API
is currently capable of.

* Remove the "all packages" and "my packages" and just present "core"
* Remove the origin switcher
* Name the side nav items more consistently
* Make /pkgs/core the default route
* Redirect to / instead of /sign-in on sign in

Signed-off-by: Nathan L Smith <[email protected]>
@smith
Copy link
Contributor Author

smith commented May 17, 2016

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit eed3daa has been approved by smith

@thesentinels
Copy link
Contributor

⌛ Testing commit eed3daa with merge 8e38059...

thesentinels pushed a commit that referenced this pull request May 17, 2016
Put the information presented to the user more in line with what the API
is currently capable of.

* Remove the "all packages" and "my packages" and just present "core"
* Remove the origin switcher
* Name the side nav items more consistently
* Make /pkgs/core the default route
* Redirect to / instead of /sign-in on sign in

Signed-off-by: Nathan L Smith <[email protected]>

Pull request: #524
Approved by: smith
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit eed3daa into master May 17, 2016
@smith smith deleted the nls/fakeaway branch May 17, 2016 03:17
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
Put the information presented to the user more in line with what the API
is currently capable of.

* Remove the "all packages" and "my packages" and just present "core"
* Remove the origin switcher
* Name the side nav items more consistently
* Make /pkgs/core the default route
* Redirect to / instead of /sign-in on sign in

Signed-off-by: Nathan L Smith <[email protected]>

Pull request: #524
Approved by: smith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants