update Rust deps #526
Merged
update Rust deps #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| set_disposition(&mut response.headers, | ||
| xfilename, | ||
| headers::Charset::Ext("utf-8".to_string())); | ||
| response.headers.set_raw("X-Filename", vec![xfilename.clone().into_bytes()]); |
There was a problem hiding this comment.
If you could drop a comment in here so we remember to switch back to set from set_raw once it's safe we can get this merged in real quick ;)
There was a problem hiding this comment.
done! thanks for the review!
bookshelfdave
force-pushed
the
dp_bump_deps
branch
2 times, most recently
from
b84019d to
062559c
Compare
added 2 commits
May 16, 2016 19:21
Signed-off-by: Dave Parfitt <[email protected]>
bookshelfdave
force-pushed
the
dp_bump_deps
branch
from
062559c to
e592eb0
Compare
|
So many deps, here we go
|
|
📌 Commit e592eb0 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 16, 2016
Pull request: #526 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
May 16, 2016
Signed-off-by: Dave Parfitt <[email protected]> Pull request: #526 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Pull request: #526 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Dave Parfitt <[email protected]> Pull request: #526 Approved by: fnichol
raskchanky
pushed a commit
that referenced
this pull request
Apr 16, 2019
Pull request: #526 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using header values created in
depot-core(Hyper 0.9) doesn't seem to work w/depot/Iron/Hyper 0.8.I'd be super happy if someone could get this to work without the set_raw hack that I used.
see also: iron/iron#452