[sup] Set appropriate PATH for sh & bash subcommands.
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change re-introduces the `bash` subcommand which was mistakenly removed (sorry y'all) and also sets an appropriate `PATH` environment variable. The logic is similar to the path-setting logic of the `start` subcommand except in this case, there is no Supervisor or service to have on path. Instead, we determine a suitable Busybox path and append any `PATH` entries at the end. This should make the Docker-wrapped services more ergonomic when using `docker exec` or similar tricks. Signed-off-by: Fletcher Nichol <[email protected]>
|
Looks great!
|
|
📌 Commit 57a559b has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 18, 2016
This change re-introduces the `bash` subcommand which was mistakenly removed (sorry y'all) and also sets an appropriate `PATH` environment variable. The logic is similar to the path-setting logic of the `start` subcommand except in this case, there is no Supervisor or service to have on path. Instead, we determine a suitable Busybox path and append any `PATH` entries at the end. This should make the Docker-wrapped services more ergonomic when using `docker exec` or similar tricks. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #531 Approved by: smith
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change re-introduces the `bash` subcommand which was mistakenly removed (sorry y'all) and also sets an appropriate `PATH` environment variable. The logic is similar to the path-setting logic of the `start` subcommand except in this case, there is no Supervisor or service to have on path. Instead, we determine a suitable Busybox path and append any `PATH` entries at the end. This should make the Docker-wrapped services more ergonomic when using `docker exec` or similar tricks. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #531 Approved by: smith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-introduces the
bashsubcommand which was mistakenlyremoved (sorry y'all) and also sets an appropriate
PATHenvironmentvariable.
The logic is similar to the path-setting logic of the
startsubcommandexcept in this case, there is no Supervisor or service to have on path.
Instead, we determine a suitable Busybox path and append any
PATHentries at the end. This should make the Docker-wrapped services more
ergonomic when using
docker execor similar tricks.