Fixes for builder-web deploy #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smith
commented
May 19, 2016
smith
commented
- Make it so nginx redirects to the http hostname, not localhost
- Fix typo in habitat.conf.js template
* Make it so nginx redirects to the http hostname, not localhost * Fix typo in habitat.conf.js template Signed-off-by: Nathan L Smith <[email protected]>
|
By analyzing the blame information on this pull request, we identified @jtimberman to be a potential reviewer |
|
I'll buy that
|
|
📌 Commit 7eae530 has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
May 19, 2016
* Make it so nginx redirects to the http hostname, not localhost * Fix typo in habitat.conf.js template Signed-off-by: Nathan L Smith <[email protected]> Pull request: #543 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
* Make it so nginx redirects to the http hostname, not localhost * Fix typo in habitat.conf.js template Signed-off-by: Nathan L Smith <[email protected]> Pull request: #543 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.